Add developer guide/integration test section #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligned with Kafka example https://github.com/opensearch-project/data-prepper/blob/51ee0df595aaad1b921c888394bf3e110ffc74e9/data-prepper-plugins/kafka-plugins/README.md#developer-guide Signed-off-by: Jürgen Walter <juergen.walter@sap.com>
juergen-walter
force-pushed
the
opensearch-plugin-test-doc
branch
from
76b5555
to
d6aa7c9
Compare
juergen-walter
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
previously approved these changes
Mar 26, 2024
chenqi0805
previously approved these changes
Mar 28, 2024
There was a problem hiding this comment.
@juergen-walter Thanks for filling in the gap. One minor inline comment
juergen-walter
commented
Apr 5, 2024
Version 2.12.0 onwards requires to use non-default admin password https://opensearch.org/blog/replacing-default-admin-credentials/ Signed-off-by: Jürgen Walter <juergen.walter@sap.com>
juergen-walter
dismissed stale reviews from chenqi0805 and dlvenable
via
3e0e686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Document how to perform integration tests for the opensearch-plugin.
This is only documentation
Aligned with Kafka example
https://github.com/opensearch-project/data-prepper/blob/51ee0df595aaad1b921c888394bf3e110ffc74e9/data-prepper-plugins/kafka-plugins/README.md#developer-guide
Issues Resolved
I am not aware of an issue, but it would have saved time for #3929 and future contributions
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.